Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply appropriate changes for K.ClassDeclaration in K.CompilationUnit getClasses and withClasses #332

Open
traceyyoshima opened this issue Oct 7, 2023 · 0 comments
Open

Apply appropriate changes for K.ClassDeclaration in K.CompilationUnit getClasses and withClasses #332

traceyyoshima opened this issue Oct 7, 2023 · 0 comments
Labels
parser-kotlin
Milestone
Kotlin Language R...

Comments

@traceyyoshima
Copy link
Contributor

Context:
We've added a K.ClassDeclaration, which will not be returned by K.CompilationUnit#getClasses and will not be accepted by K.CompilationUnit#withClasses.

Unless something has changed, getClasses() will be used by Java recipes, and the J.ClassDeclaration in the K.ClassDeclaration should be returned in the list. Additionally, withClasses may be deprecated since it may lead to unexpected results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parser-kotlin
Projects
OpenRewrite
Status: Backlog
Milestone
Kotlin Language Readiness
Development

No branches or pull requests
2 participants
@timtebeek @traceyyoshima