Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error: Idempotent print issue on top-level method invocation. #460

Open
traceyyoshima opened this issue Nov 21, 2023 · 4 comments
Open
Assignees
Labels
bug Something isn't working parser-kotlin priority:low question Further information is requested

Comments

@traceyyoshima
Copy link
Contributor

traceyyoshima commented Nov 21, 2023

Update:
context(...) is a syntax for an experimental feature called Context Receivers.

This PR will enable context receivers in the compiler.

@traceyyoshima traceyyoshima added the bug Something isn't working label Nov 21, 2023
@traceyyoshima traceyyoshima changed the title Parsing error: Idempotent print issue on top-level method invocation. Priority High. Status blocked. Parsing error: Idempotent print issue on top-level method invocation. Dec 20, 2023
@traceyyoshima
Copy link
Contributor Author

traceyyoshima commented Dec 20, 2023

This requires @sambsnyd since we cannot reproduce the issue. reproduced on: https://github.com/RBusarow/ModuleCheck/blob/main
modulecheck-internal-testing/src/main/kotlin/modulecheck/testing/TestNodeBuilder.kt

@traceyyoshima traceyyoshima changed the title Priority High. Status blocked. Parsing error: Idempotent print issue on top-level method invocation. Parsing error: Idempotent print issue on top-level method invocation. Dec 20, 2023
@traceyyoshima traceyyoshima self-assigned this Dec 21, 2023
@traceyyoshima traceyyoshima moved this to In Progress in OpenRewrite Dec 21, 2023
@traceyyoshima
Copy link
Contributor Author

@knutwannheden I had placed this issue as priority:high due to the number of occurrences in client code (on one project). However, the parsing issue is related to an experimental feature in the Kotlin compiler that was added in 1.6.x. There are still a lot of bugs based on this issue Kotlin/KEEP#259, and I think it's reasonable not to support them in the LST for now.

What do you think?

@traceyyoshima traceyyoshima moved this from In Progress to Ready to Review in OpenRewrite Dec 22, 2023
@traceyyoshima traceyyoshima added the question Further information is requested label Dec 22, 2023
@knutwannheden
Copy link
Contributor

Yes sounds reasonable. Thanks for investigating.

@traceyyoshima traceyyoshima moved this from Ready to Review to Backlog in OpenRewrite Dec 22, 2023
@traceyyoshima
Copy link
Contributor Author

Placed back in the backlog -- this is an experimental feature in the compiler that still has many bugs. We can prioritize this when the feature is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser-kotlin priority:low question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

3 participants