-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve quality of LST: replace applicable markers with LST elements #477
Comments
For |
|
How does this work for the requirements of |
I double checked
the space before
so I think the prefix in this marker is not necessary, we can just deprecate the |
Let's also try to be careful to not break LST deserialization as we do these refactorings. In moderne-ast-write we can set up regression tests, so that we know if we need to customize deserialization or not. |
Replace:
The
J
tree expectsJ.Annotation
(s), a final class. InK
, there is an additional suffix after the use site annotation like@file : ...
. This change may require an update toJ.Annotation
since various classes require it.Nullable is a generally applicable concept across
J
and every implementation ofJ
, and may be generally fixable. DeprecateIsNullable
marker and useK.Unary
instead #489Deprecate
IsNullable
marker and useJ.NullableType
instead #497Possible solution: Add an IsNullSafe
Expression
pass-through to contain the applicable expression.J.Modifier#keyword
, and appears to still be in use.Possible solution: Add a TypeReference
TypeTree
tree to contain the applicable expression.Update:
This marker exists in both Groovy and Kotlin, and will likely be reused elsewhere. We should probably add this to rewrite-java and use the reuse the marker.
The text was updated successfully, but these errors were encountered: