-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge all emission files into a SCEN7 format #237
Comments
@rgieseke Thoughts? Flattening all emissions wasn't as simple as we would have liked... |
I think there's a step 1a) update pymagicc to write multiple input scenario files, splitting things by their region code. Errors would be thrown if the region code can't be determined for a given variable and if there is both world and disaggregated region data for a given variable (forcing the user to choose what to use before passing it into |
That's more like an additional bullet than 1a. In that case, does it make sense to raise a warning at all for MAGICC7 as that seems like a logical way of handling the multiple emisscen values. My hesitation would be that it adds more complexity than blindly passing through the emissscen_x params? I'll add in a func to process multiple emisscen's which for now is effectively a noop, but in future could reduce the emissions files if needed. |
Ohh actually the current setup should work - the check_config only checks if the MAGCFG_USER.CFG file is correct and valid. So any additional config passed to The following script uses multiple emisscen files as confirmed by the log messages:
|
I think whilst MAGICC7 is still private, let's just do whatever works for us. When it goes public, if it has the ability to run with multiple
There might be one major gotcha with this (I need to double check when we actually start implementing...), users might have to supply emissions for a number of minor species that they wouldn't normally think about. The reason is that without supplied emissions, MAGICC7 assumes emissions are zero and hence the concentrations of these species can plummet, blowing up the whole run. In that case, we might have to automatically supply emissions of these species if they're not there, throwing a warning in the process to let people know we've done this. The better solution would be to fix MAGICC so this doesn't happen but that might not be possible on the timelines we need. |
Describe the bug
When reading a SCEN7 file with a region mode of other than World, all World region data is ignored. This makes it impossible to merge World-only emissions with emissions disaggregated by region.
Possible options to resolve this:
pymagicc
. Effectively multiplication using theGEN_SRESREGIONS2NH
variable.For now, 1. is the simplest, with that warning eventually being replaced with a ValueError again
The text was updated successfully, but these errors were encountered: