Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing file_tuningmodel_x flags #241

Open
znicholls opened this issue Apr 23, 2019 · 0 comments
Open

Deprecate passing file_tuningmodel_x flags #241

znicholls opened this issue Apr 23, 2019 · 0 comments

Comments

@znicholls
Copy link
Collaborator

These flags allow the user to specify other files from which pymagicc should read config. They are hugely confusing to use and can cause unexpected behaviour. For our sanity, we should prevent users from using them, instead providing a convenience function load_tuningmodel_cfg which can take a list of tuningmodels and merge them into a config which can then be passed to MAGICC.run. This gets the config blending into Python, where it's simple to debug, and out of the calls to ./magicc, where it's much harder to debug.

@lewisjared or @znicholls will have a go unless someone else gets there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant