Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space-assignment syntax in Groovy DSL has been deprecated. #1061

Open
dbwiddis opened this issue Feb 10, 2025 · 0 comments
Open

Space-assignment syntax in Groovy DSL has been deprecated. #1061

dbwiddis opened this issue Feb 10, 2025 · 0 comments
Labels
backport 2.x backport PRs to 2.x branch good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Feb 10, 2025

What is the bug?

See: https://docs.gradle.org/8.12.1/userguide/upgrading_version_8.html#groovy_space_assignment_syntax

In our build.gradle we need to change propertyName value syntax to one of:

propertyName = value
setPropertyName(value)
setPropertyName value
propertyName(value)

I prefer the top or bottom options. Consistency with the other settings around it is probably more important for readability, e.g. for dependencies we should probably switch to propertyName(value) but in other places where = is used we should use propertyName = value.

How can one reproduce the bug?

  1. Run ./gradlew test from the project root
  2. Observe a file output of a "Problem Report" with a link. Mine looks like:
[Incubating] Problems report is available at: file:///Users/dbwiddis/git/flow-framework/build/reports/problems/problems-report.html
  1. Open that report in your browser.
  2. You'll see several lines in build.gradle marked with this error:

Space-assignment syntax in Groovy DSL has been deprecated.

What is the expected behavior?

No problems report, repo is ready for Gradle 10

What is your host/environment?

Gradle 8 with deprecation warnings in an incubating problems report

Do you have any screenshots?

Image

@dbwiddis dbwiddis added backport 2.x backport PRs to 2.x branch good first issue Good for newcomers help wanted Extra attention is needed labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant