Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUTOCUT] Integration Test Failed for k-NN-2.19.0 #2458

Open
opensearch-ci-bot opened this issue Jan 28, 2025 · 6 comments · May be fixed by #2463
Open

[AUTOCUT] Integration Test Failed for k-NN-2.19.0 #2458

opensearch-ci-bot opened this issue Jan 28, 2025 · 6 comments · May be fixed by #2463
Labels
autocut untriaged v2.19.0

Comments

@opensearch-ci-bot
Copy link
Collaborator

opensearch-ci-bot commented Jan 28, 2025 •
edited
Loading

Integration Test Failed for version 2.19.0. See the specifications below:

Details

Platform Dist Arch Dist Build No. RC Test Report Workflow Run Failing tests
linux tar x64 10772 1 https://ci.opensearch.org/ci/dbc/integ-test/2.19.0/10772/linux/x64/tar/test-results/9317/integ-test/test-report.yml https://build.ci.opensearch.org/job/integ-test/9317/display/redirect Check metrics
linux tar x64 10772 1 https://ci.opensearch.org/ci/dbc/integ-test/2.19.0/10772/linux/x64/tar/test-results/9318/integ-test/test-report.yml https://build.ci.opensearch.org/job/integ-test/9318/display/redirect Check metrics

Check out test report manifest linked above for steps to reproduce, cluster and integration test failure logs. For additional information checkout the wiki and OpenSearch Metrics Dashboard.

Tagging the release owners to take a look @kotwanikunal
@kotwanikunal
Copy link
Member

Test Failures:

testKnnSettingCanBeIgnored_whenRestore_thenSuccess

@kotwanikunal
Copy link
Member 

EPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.index.RestoreSnapshotIT.testKnnSettingIsModifiable_whenRestore_thenSuccess" -Dtests.seed=6F3E1A3C9D9E53F4 -Dtests.security.manager=false -Dtests.locale=bg-BG -Dtests.timezone=Japan -Druntime.java=21



REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.index.RestoreSnapshotIT.testKnnSettingCanBeIgnored_whenRestore_thenSuccess" -Dtests.seed=6F3E1A3C9D9E53F4 -Dtests.security.manager=false -Dtests.locale=bg-BG -Dtests.timezone=Japan -Druntime.java=21



REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.index.RestoreSnapshotIT.testKnnSettingCannotBeIgnored_whenRestore_thenFailure" -Dtests.seed=6F3E1A3C9D9E53F4 -Dtests.security.manager=false -Dtests.locale=bg-BG -Dtests.timezone=Japan -Druntime.java=21



REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.index.RestoreSnapshotIT.testKnnSettingIsUnmodifiable_whenRestore_thenFailure" -Dtests.seed=6F3E1A3C9D9E53F4 -Dtests.security.manager=false -Dtests.locale=bg-BG -Dtests.timezone=Japan -Druntime.java=21





Suite: Test class org.opensearch.knn.index.RestoreSnapshotIT

  2> REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.index.RestoreSnapshotIT.testKnnSettingIsModifiable_whenRestore_thenSuccess" -Dtests.seed=6F3E1A3C9D9E53F4 -Dtests.security.manager=false -Dtests.locale=bg-BG -Dtests.timezone=Japan -Druntime.java=21

  2> java.lang.AssertionError: 

    Expected: a collection with size <1>

         but: collection size was <0>

        at __randomizedtesting.SeedInfo.seed([6F3E1A3C9D9E53F4:3B133CC9D7FCAAF9]:0)

        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)

        at org.junit.Assert.assertThat(Assert.java:964)

        at org.junit.Assert.assertThat(Assert.java:930)

        at org.opensearch.knn.KNNRestTestCase.setupSnapshotRestore(KNNRestTestCase.java:1997)

        at org.opensearch.knn.index.RestoreSnapshotIT.setUp(RestoreSnapshotIT.java:29)

  2> REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.knn.index.RestoreSnapshotIT.testKnnSettingCanBeIgnored_whenRestore_thenSuccess" -Dtests.seed=6F3E1A3C9D9E53F4 -Dtests.security.manager=false -Dtests.locale=bg-BG -Dtests.timezone=Japan -Druntime.java=21

  2> java.lang.AssertionError: 

    Expected: a collection with size <1>

         but: collection size was <0>

        at __randomizedtesting.SeedInfo.seed([6F3E1A3C9D9E53F4:D89A96940FFDC5C9]:0)

        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)

        at org.junit.Assert.assertThat(Assert.java:964)

        at org.junit.Assert.assertThat(Assert.java:930)

        at org.opensearch.knn.KNNRestTestCase.setupSnapshotRestore(KNNRestTestCase.java:1997)

        at org.opensearch.knn.index.RestoreSnapshotIT.setUp(RestoreSnapshotIT.java:29)

@kotwanikunal
Copy link
Member

Reached out to @anntians to take a look at the failing test.

@anntians
Copy link
Contributor

The failure is due to https://github.com/opensearch-project/k-NN/blob/2.x/src/testFixtures/java/org/opensearch/knn/KNNRestTestCase.java#L1997, which gets the path.repo of the test cluster used to register snapshot repository. In the test we expect the path.repo to have size 1, but not sure why it's 0 here. All checks of the original 2.x PR #2445 passed. There is an open PR to backport to main #2455. Is it possible for test clusters to be spun up without a path.repo on the machine?

@kotwanikunal
Copy link
Member

The failure is due to https://github.com/opensearch-project/k-NN/blob/2.x/src/testFixtures/java/org/opensearch/knn/KNNRestTestCase.java#L1997, which gets the path.repo of the test cluster used to register snapshot repository. In the test we expect the path.repo to have size 1, but not sure why it's 0 here. All checks of the original 2.x PR #2445 passed. There is an open PR to backport to main #2455. Is it possible for test clusters to be spun up without a path.repo on the machine?

@anntians Yes. The test configuration can be customized. Can you please look into the CI runs and get the test config? Or explicitly setup a repository for your tests? (https://github.com/opensearch-project/OpenSearch/blob/main/client/rest-high-level/src/main/java/org/opensearch/client/SnapshotClient.java#L122-L130)

This was referenced Jan 28, 2025
Merged
Open
@kotwanikunal
Copy link
Member

@anntians The test is still failing: https://build.ci.opensearch.org/blue/rest/organizations/jenkins/pipelines/integ-test/runs/9318/nodes/90/steps/246/log/?start=0
Can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
autocut untriaged v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Backport Main] Add path.repo for registering snapshot repository in integ tests anntians/k-NN
3 participants
@kotwanikunal @anntians @opensearch-ci-bot