-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] The docs refer to the demo directory, however it isn't in our code base. #43
Comments
Good candidate for @JohannesDaniel to pick up... |
@epugh it looks like this was edited out of the docs. Okay to close? |
I suppose so... Did we add back the docs though? I see https://github.com/opensearch-project/opensearch-learning-to-rank-base/tree/main/demo, is that the missing dir? Looking back at the original docs, they pointed to https://github.com/o19s/elasticsearch-learning-to-rank/tree/main/demo. So I think the right fix is to add a PR to the docs website restoring the link to our |
I agree. After doing a bit of code archeology I found that most of what was in the demo directory was moved to hello-ltr. So, the link at the top of the page should go to that site instead of referencing this demo directory. |
What is the bug?
In the docs, that we are coping over, we have http://localhost:4000/docs/latest/search-plugins/ltr/logging-features/ page that says:
However, that link, which should be https://github.com/o19s/OpenSearch-learning-to-rank/tree/master/demo doesn't work because that directory was never ported over.
How can one reproduce the bug?
Use this PR for the documentation and stand it up: opensearch-project/documentation-website#8336
What is the expected behavior?
Either the link works, or we rework it to not have a link
The text was updated successfully, but these errors were encountered: