We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, Thank you for this great project
Add or improve type hints more and more in this library.
There is something I notice when using this library.
The type hint Any is used everywhere in this project. For example, it is clear that the Document.search() method returns a Search instance.
Any
Search
opensearch-py/opensearchpy/helpers/document.py
Line 198 in 7336f51
This makes the library interface clearer and contributes to improved usability. In particular, it has benefit when using high-level APIs.
All we have to do is write the correct type hints for every function and method. It does not affect the behavior of this library.
Are you maintainers in favor of improving the type hints? Or do you prefer separate stubs? (Just like django-stubs)
The text was updated successfully, but these errors were encountered:
Yes, please, definitely in favor! Much of this code is generated so that's where I'd make most changes.
Sorry, something went wrong.
No branches or pull requests
Hi, Thank you for this great project
What/Why
What are you proposing?
Add or improve type hints more and more in this library.
What problems are you trying to solve?
There is something I notice when using this library.
The type hint
Any
is used everywhere in this project.For example, it is clear that the Document.search() method returns a
Search
instance.opensearch-py/opensearchpy/helpers/document.py
Line 198 in 7336f51
What is the user experience going to be?
This makes the library interface clearer and contributes to improved usability.
In particular, it has benefit when using high-level APIs.
What will it take to execute?
All we have to do is write the correct type hints for every function and method.
It does not affect the behavior of this library.
Are you maintainers in favor of improving the type hints? Or do you prefer separate stubs? (Just like django-stubs)
The text was updated successfully, but these errors were encountered: