This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
fix(connectivity): return early on fatal errors #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain errors in connectivity pod-to-pod checks prevent further meaningful checks in pod connectivity from being run. The following failures are irrecoverable roadblocks preventing the checks from being run, so osm-health should terminate upon encountering any of these. (1) failure to initialize the k8s client, (2) failure to obtain the kubeconfig, or (3) failure to obtain osm info (possibly due to incorrect mesh namespace specified) Signed-off-by: Johnson Shi <[email protected]>
johnsonshi
force-pushed
the
early-return-on-fatal-errors
branch
from
06850cb to
5dfae38
Compare
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 42.13% 42.13%
=======================================
Files 31 31
Lines 1272 1272
=======================================
Hits 536 536
Misses 736 736
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
johnsonshi
commented
Jan 3, 2022
pkg/osm/version/types_test.go
Outdated
| @@ -15,7 +15,7 @@ func TestEnvoyConfigParser(t *testing.T) { | |||
| assert := tassert.New(t) | |||
| actual := getReleases() | |||
|
|
|||
| assert.Equal([]string{"v0.10", "v0.11", "v0.6", "v0.7", "v0.8", "v0.9"}, actual) | |||
| assert.Equal([]string{"v0.10", "v0.11", "v0.7", "v0.8", "v0.9"}, actual) | |||
There was a problem hiding this comment.
Needed to pass unit tests as v0.6 is not supported anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain errors in connectivity pod-to-pod checks prevent
further meaningful checks in pod connectivity from being
run. The following failures are irrecoverable roadblocks
preventing the checks from being run, so osm-health should
terminate upon encountering any of these.
(1) failure to initialize the k8s client,
(2) failure to obtain the kubeconfig, or
(3) failure to obtain osm info (possibly due to incorrect
mesh namespace specified)
Resolves #107.
Signed-off-by: Johnson Shi [email protected]