Buildbot build should be "Changed by" the gerrit "patchset.uploader" rather than the gerrit "change.owner"

[morrone]

In the waterfall, gerrit is listing the name of the person that owns the overall gerrit change, rather than the name of the person who actually pushed that version of the patch. I think the latter would be much more understandable for the Lustre project.

[morrone]

http://build.lustre.org/changes/1337 is a good example right now. "pratik.shinde" is listed as the change owner under "Event.change.owner.username" in buildbot.

Probably we want the change name to come from the committer field. It looks like buildbot has that information under "Event.patchset.uploader.name".

So it looks like we want the buildbot build to be listed as "Changed by" the Event.patchset.uploader rather than the current Event.change.owner.

[dinatale2]

Maybe it's due to the lack of experience with the Gerrit submission process, but why is Event.patchset.uploader.name more significant than Event.change.owner.username? Isn't Event.change.owner.username the person who originally made the patch?

[morrone]

Event.change.owner.username is the person who originally pushed (or maybe the patch author on the first push, I'm not sure).

But that isn't too useful when looking at a build in the build farm. We would really rather know who is responsible for the change event and associated builds, and the was the person who did the push. Some patches are long lived, and go through multiple different people pushing the patch. If I take over work on a patch in gerrit and do a push, I want to see my name as responsible for the builds in buildbot. Because I'll be confused if I have to look for some other persons name for the build that I started.

Likewise, if someone else pushes an update to a patch the I originated, I would be a little surprised to see my own name next to a build that I didn't initiate.