Skip to content

Commit

Permalink
Allow skipping make generate-release in e2e_new_tests (#865)
Browse files Browse the repository at this point in the history
In SO CI the permission error will fail the test, so we need to
skip in when running tests in that repository.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
  • Loading branch information
pierDipi authored Oct 18, 2023
1 parent fed9a33 commit 432aded
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion openshift/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ export SYSTEM_NAMESPACE=$EVENTING_NAMESPACE
export TRACING_NAMESPACE=$EVENTING_NAMESPACE
export KNATIVE_DEFAULT_NAMESPACE=$EVENTING_NAMESPACE

export SKIP_GENERATE_RELEASE=${SKIP_GENERATE_RELEASE:-false}

default_test_image_template=$(
cat <<-END
{{- with .Name }}
Expand Down Expand Up @@ -108,7 +110,10 @@ function run_conformance_tests() {
function run_e2e_new_tests() {
export BROKER_CLASS="Kafka"

make generate-release
if [ "$SKIP_GENERATE_RELEASE" = false ]; then
make generate-release
fi

images_file=$(dirname $(realpath "$0"))/images.yaml
cat "${images_file}"

Expand Down

0 comments on commit 432aded

Please sign in to comment.