-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.13] wathola receiver, annotate span by step number #528
base: release-v1.12
Are you sure you want to change the base?
Conversation
/cherry-pick release-v1.12 |
@maschmid: once the present PR merges, I will cherry-pick it on top of release-v1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v1.11 |
@maschmid: once the present PR merges, I will cherry-pick it on top of release-v1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
@maschmid we fixed a couple of issues in 1.13 (which lead to some CI failures). Can you rebase this PR? |
392546d
to
61cffda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, maschmid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Revision 61cffda was retested 3 times: holding |
/retest |
1 similar comment
/retest |
/unhold |
/retest not sure why now all fail, after all was green .... |
/retest-required |
|
/hold Revision 61cffda was retested 3 times: holding |
@maschmid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
backports knative#7667