purge status events #232
Open
purge status events #232
+450
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
reviewed
Dec 17, 2024
| @@ -22,7 +22,7 @@ func addConsumers() *gormigrate.Migration { | |||
| } | |||
|
|
|||
| if err := CreateFK(tx, fkMigration{ | |||
| "resources", "consumers", "consumer_name", "consumers(name)", | |||
| "resources", "consumers", "consumer_name", "consumers(name)", "ON DELETE RESTRICT ON UPDATE RESTRICT", | |||
There was a problem hiding this comment.
from SRE comments, we can't modify existing migrations, we need to create new migration to ensure their data can migrated to new schema.
There was a problem hiding this comment.
This change will not effect the db, the change due to refact the CreateFK (make it can support configing constrains )
For the event-instances part, I create a new migration to ensure the db update
skeeey
force-pushed
the
purge-se
branch
2 times, most recently
from
99fe3fe to
da93fe9
Compare
|
/ok-to-test |
morvencao
reviewed
Dec 19, 2024
pkg/dao/mocks/instance.go
Outdated
| @@ -136,6 +136,10 @@ func (d *instanceDaoMock) FindByUpdatedTime(ctx context.Context, updatedTime tim | |||
| return instances, nil | |||
| } | |||
|
|
|||
| func (d *instanceDaoMock) FindReadyIDs(ctx context.Context) ([]string, error) { | |||
| return []string{}, nil | |||
There was a problem hiding this comment.
we can check if instance Ready == true from instances list, instead of return empty slice. this is useful for testing.
| "event_instances", "server_instances", "instance_id", "server_instances(id)", "ON DELETE CASCADE", | ||
| }, fkMigration{ | ||
| "event_instances", "status_events", "event_id", "status_events(id)", "ON DELETE CASCADE", | ||
| }) |
There was a problem hiding this comment.
would you alse add foreign key for spec_event_id on events table?
|
/ok-to-test |
|
/ok-to-test |
|
/ok-to-test |
Signed-off-by: Wei Liu <[email protected]>
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.