From 5b60bbf2c723959d2726bd7797846298382cdfe4 Mon Sep 17 00:00:00 2001
From: tsivakum <tsivakum@redhat.com>
Date: Wed, 27 Sep 2023 18:23:57 +0100
Subject: [PATCH] added failure tests for list machinepools command

---
 tests/list_machinepools_test.go | 70 +++++++++++++++++++++++++++++++--
 1 file changed, 67 insertions(+), 3 deletions(-)

diff --git a/tests/list_machinepools_test.go b/tests/list_machinepools_test.go
index 03e15342..77347ecc 100644
--- a/tests/list_machinepools_test.go
+++ b/tests/list_machinepools_test.go
@@ -53,10 +53,10 @@ var _ = Describe("List machine pools", Ordered, func() {
 			"id":"my-cluster",
 			"subscription": {"id":"subsID"},
 			"state":"ready"
-			}]	
+			}]
 	  }`
 
-	BeforeAll(func() {
+	BeforeEach(func() {
 		// Create a context:
 		ctx = context.Background()
 
@@ -86,7 +86,7 @@ var _ = Describe("List machine pools", Ordered, func() {
 		config = result.ConfigString()
 	})
 
-	AfterAll(func() {
+	AfterEach(func() {
 		// Close the servers:
 		ssoServer.Close()
 		apiServer.Close()
@@ -186,4 +186,68 @@ var _ = Describe("List machine pools", Ordered, func() {
 			`^default\s+No\s+2\s+m5.xlarge\s+us-west-2a$`,
 		))
 	})
+
+	It("Fail on invalid cluster key", func() {
+		apiServer.AppendHandlers(
+			RespondWithJSON(http.StatusOK, subscriptionInfo),
+		)
+
+		// Run the command:
+		result := NewCommand().
+			ConfigString(config).
+			Args(
+				"list", "machinepools",
+				"--cluster", "invalid!cluster",
+			).Run(ctx)
+
+		Expect(result.ExitCode()).ToNot(BeZero())
+		Expect(result.ErrString()).To(ContainSubstring("Cluster name, identifier or external identifier"))
+		Expect(result.ErrString()).To(ContainSubstring("isn't valid"))
+	})
+
+	It("Fail on non-existing cluster", func() {
+		apiServer.AppendHandlers(
+			RespondWithJSON(http.StatusOK, subscriptionInfo),
+			RespondWith(http.StatusNotFound, `{}`),
+		)
+
+		// Run the command:
+		result := NewCommand().
+			ConfigString(config).
+			Args(
+				"list", "machinepools",
+				"--cluster", "my-cluster",
+			).Run(ctx)
+
+		Expect(result.ExitCode()).ToNot(BeZero())
+		Expect(result.ErrString()).To(ContainSubstring("Failed to get cluster"))
+	})
+
+	It("Fail when cluster is not in ready state", func() {
+		apiServer.AppendHandlers(
+			RespondWithJSON(http.StatusOK, subscriptionInfo),
+			RespondWithJSON(http.StatusOK, `{
+				"kind": "ClusterList",
+				"total": 1,
+				"items": [
+					{
+					"kind":"Cluster",
+					"id":"my-cluster",
+					"subscription": {"id":"subsID"},
+					"state":"waiting"
+					}]
+			  }`),
+		)
+
+		// Run the command:
+		result := NewCommand().
+			ConfigString(config).
+			Args(
+				"list", "machinepools",
+				"--cluster", "my-cluster",
+			).Run(ctx)
+
+		Expect(result.ExitCode()).ToNot(BeZero())
+		Expect(result.ErrString()).To(ContainSubstring("is not yet ready"))
+	})
 })