[3] Increase test coverage in fabric8-analytics-license-analysis repository to > 90%

[tisnik]

Acceptance criteria

• test coverage above 90%
• all modules are covered
• code coverage displayed on the QA Dashboard

Additional info

https://openshift.io/openshiftio/openshiftio/plan/detail/2464

[sara-02]

@tisnik I and Sunil will be helping you with this issue.
In addition, I would like to take this time to work on issues
fabric8-analytics/fabric8-analytics-license-analysis#33
fabric8-analytics/fabric8-analytics-license-analysis#32
and fabric8-analytics/fabric8-analytics-license-analysis#14
I know that they don't belong to this issue, but it can help in cleaning up the repo while adding the tests. WDYT? Should I add them to #3522 instead?

[tisnik]

Updated via fabric8-analytics/fabric8-analytics-license-analysis#103

[tisnik]

Current status:

Name                                                       Stmts   Miss  Cover   Missing
----------------------------------------------------------------------------------------
/root/payload/src/__init__.py                                  0      0   100%
/root/payload/src/auth.py                                     66     25    62%   22, 57, 68-97
/root/payload/src/config.py                                   10      0   100%
/root/payload/src/directed_graph.py                           87      0   100%
/root/payload/src/exceptions.py                                5      0   100%
/root/payload/src/license_analysis.py                        273      0   100%
/root/payload/src/rest_api.py                                 34      5    85%   15-16, 21-22, 70
/root/payload/src/stack_license.py                           273     33    88%   23-28, 380, 398, 402-410, 435, 438-445, 451-468
/root/payload/src/util/__init__.py                             0      0   100%
/root/payload/src/util/data_store/__init__.py                  0      0   100%
/root/payload/src/util/data_store/abstract_data_store.py      10      0   100%
/root/payload/src/util/data_store/local_filesystem.py         44      0   100%
/root/payload/src/util/data_store/s3_data_store.py            61      0   100%
/root/payload/src/utils.py                                    18     16    11%   7-29
----------------------------------------------------------------------------------------
TOTAL                                                        881     79    91%

[tisnik]

thanks @sara-02 , but we are already on 91%. Sure, the tests needs to be updated... :)

[tisnik]

@sara-02 yes, the #3522 needs to be implemented as well. I've updated the code a bit to lower the cyclomatic complexity, but the rest might be up to you :)