feat: add fail_on_error parameter support on github actions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subashcs
force-pushed
the
fail_on_error
branch
from
1a4b8f1 to
c96ff0b
Compare
aj3sh
requested changes
Feb 22, 2024
subashcs
force-pushed
the
fail_on_error
branch
from
1cc89e5 to
087d694
Compare
subashcs
force-pushed
the
fail_on_error
branch
from
087d694 to
00bf73f
Compare
aj3sh
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current GitHub Actions fail if
commitlintthrows an error.This pull request adds a new boolean parameter, fail_on_error, to GitHub Actions. This parameter will determine whether to fail the CI or proceed to the next step when
commitlintthrows an error. The default value for this parameter will betrue.The fail_on_error parameter is set to false when the user wants to ignore the commit message validation or handle the error in their own way.
Related Issue
Fixes #14
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug","feat(accounts): Added foobar feature".README.md.By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.