feat: enhanced error message #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj3sh
force-pushed
the
message-enhancement
branch
5 times, most recently
from
ea66ef4
to
f572caa
Compare
subashcs
reviewed
Mar 17, 2024
subashcs
reviewed
Mar 17, 2024
subashcs
requested changes
Mar 21, 2024
aj3sh
force-pushed
the
message-enhancement
branch
from
f572caa
to
a2aef20
Compare
aj3sh
force-pushed
the
message-enhancement
branch
from
a2aef20
to
fdcd125
Compare
subashcs
approved these changes
Mar 27, 2024
sugat009
requested changes
Mar 29, 2024
aj3sh
force-pushed
the
message-enhancement
branch
from
3d74fe5
to
9c94754
Compare
- Removed old `commitlint.py`. - Added new module `linter` for linting and validation. - Added detailed validation on `linter` for message enhancement. - Added new error messages. - Added option `--skip-detail` for simple linting. - Moved old validation to simple linting. - Added `pytest.ini` for adding src as a python path. - Updated test for both detailed and simple with same test data. Co-authored-by: Sugat Bajracharya <[email protected]>
aj3sh
force-pushed
the
message-enhancement
branch
from
9c94754
to
9a8c081
Compare
sugat009
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very large PR. It includes changes for detailed validation to enhance the error message. The previous validation has been almost completely changed.
Below are the breakdown of the changes:
commitlint.py.linterfor linting and validation.linterfor message enhancement.--skip-detailfor simple linting.pytest.inifor adding src as a Python path.Related Issue
Fixes #12
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug","feat(accounts): Added foobar feature".I have added/updated the necessary documentation onREADME.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.