Sources: Some defillama assets are failing to materialize

[ravenac95]

Which area(s) are affected? (leave empty if unsure)

No response

To Reproduce

See: https://dagster.opensource.observer/runs/00c38c05-802f-409e-bc35-2afd3eba7728

Describe the Bug

Some things seem to be faililng still. Not high urgency but we should debug to see what's up.

Expected Behavior

These things should succeed.

[Jabolol]

The underlying issue is that we are asking DefiLlama for invalid slugs. For instance:

(.venv) jabolo@oso-polar-v2:~/oso$ curl -I https://api.llama.fi/protocols/mode
HTTP/2 404 
date: Wed, 15 Jan 2025 10:29:04 GMT

...

Here are the steps on how to check if a protocol exists: #2681 (comment). And here are all the invalid slugs we currently have:

Protocols that do not exist: ['ether.fi', 'compound-finance', 'lisk', 'derive', 'contango', 'kelp-dao', 'resolv', 'kroma', 'uniswap', 'velodrome', 'origin', 'origin-protocol', 'polynomial-protocol', 'extra-finance', 'frax-finance', 'mode']

I do not know which protocols exactly we need. Maybe @evanameyer1 can help us choose the ones he needs :)

Protocol with slug 'ether.fi' does not exist. Similar ones: ['ether.fi-stake', 'ether.fi-vaults', 'ether.fi-liquid', 'nether.fi']
Protocol with slug 'compound-finance' does not exist. Similar ones: []
Protocol with slug 'lisk' does not exist. Similar ones: ['obeliskbtc', 'lisk-bridge', 'basilisk']
Protocol with slug 'derive' does not exist. Similar ones: ['derive-v2', 'derive-v1', 'derive-options']
Protocol with slug 'contango' does not exist. Similar ones: ['contango-v2', 'contango-v1']
Protocol with slug 'kelp-dao' does not exist. Similar ones: []
Protocol with slug 'resolv' does not exist. Similar ones: ['resolv-usr', 'resolv-rlp']
Protocol with slug 'kroma' does not exist. Similar ones: ['wemix-on-kroma', 'kromatika']
Protocol with slug 'uniswap' does not exist. Similar ones: ['uniswap-v3', 'uniswap-v2', 'uniswap-v1', 'uniswap-labs']
Protocol with slug 'velodrome' does not exist. Similar ones: ['velodrome-v2', 'velodrome-v3', 'velodrome-v1']
Protocol with slug 'origin' does not exist. Similar ones: ['origin-ether', 'origin-arm', 'origin-dollar']
Protocol with slug 'origin-protocol' does not exist. Similar ones: []
Protocol with slug 'polynomial-protocol' does not exist. Similar ones: []
Protocol with slug 'extra-finance' does not exist. Similar ones: ['extra-finance-leverage-farming', 'extra-finance-xlend']
Protocol with slug 'frax-finance' does not exist. Similar ones: []
Protocol with slug 'mode' does not exist. Similar ones: ['mode-bridge', 'swapmode-v2', 'powpeg-fast-mode', 'swapmode-v3', 'betmode', 'modemax-perps-v2', 'modemax-perps', 'modemax-amm', 'modeswap', 'standard-protocol-mode']

[ryscheng]

FYI, I'm adding a DefiLlama validator here
#2791

What this means is that we'll automatically validate defillama URLs in oss-directory like this
opensource-observer/oss-directory#623

Once we start using that as the source of truth, then I think this issue is moot

[evanameyer1]

@Jabolol Sorry, just saw your message now.

Thanks for the clarification, I realize now I completely misunderstood how we accessed defillama data, hence so many invalid slugs! I can fix this now.

The only thing is I'm not always 100% sure of which exact protocol corresponds to each project. For now I'll update the defillama links in the oss-directory to the best of my ability here: opensource-observer/insights#115 (comment), so that way I can use @ryscheng's new validator and we can at least ensure all links are real.

Maybe @ccerv1 @Jabolol could we set up a call after I add my initial guesses of which links correspond to help validate some of the protocols that I selected? Just want to make sure I select the right one for each project.

[evanameyer1]

I updated the relevant s6 growth grant projects .yml file with defillama links here: opensource-observer/oss-directory#633

[ryscheng]

Let's say the remaining scope on this issue is to connect the oss-directory data to the DefiLlama staging models as the source of truth on which defillama slugs to pull