Various perf tools improvements #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
t8m
commented
Jun 6, 2024
t8m
commented
- make it easier to build against OpenSSL 1.1.1
- adjust the test iterations to even out the test runtimes
- fix bug in evp_fetch test when running with explicit type
nhorman
approved these changes
Jun 6, 2024
Sashan
approved these changes
Jun 6, 2024
Sashan
reviewed
Jun 7, 2024
|
@openssl/otc please review. |
|
ACK, approval holds |
- make it easier to build against OpenSSL 1.1.1 - adjust the test iterations to even out the test runtimes - fix bug in evp_fetch test when running with explicit type
|
A few more changes were needed. @mattcaswell @levitte please review. |
Sashan
approved these changes
Jun 17, 2024
|
Merged. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2024
- make it easier to build against OpenSSL 1.1.1 - adjust the test iterations to even out the test runtimes - fix bug in evp_fetch test when running with explicit type Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Sasa Nedvedicky <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #200)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 17, 2024
Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Sasa Nedvedicky <[email protected]> Reviewed-by: Richard Levitte <[email protected]> (Merged from #200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.