-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ssl config switch test to ceph-dashboard #1090
Adds ssl config switch test to ceph-dashboard #1090
Conversation
eaa4ce3
to
d05f49c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, lgtm in general, some small nits/questions inline -- thanks!
b3f681d
to
39c4a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting a hold on this; there's some code strangeness that I'd like to comment on.
Signed-off-by: Utkarsh Bhatt <[email protected]>
39c4a76
to
c0b2a2c
Compare
The fix adds event based handling of SSL configuration using charm config and cleanup of SSL for relation and config based key/certs. It also adds logical abstractions to analyse SSL setup and emit relevant events. Closes-Bug: 1952282 Change-Id: Ic486434526f639f5985cfe355e303c1d6ff5fa0d Signed-off-by: utkarshbhatthere <[email protected]> func-test-pr: openstack-charmers/zaza-openstack-tests#1090
No description provided.