Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ssl config switch test to ceph-dashboard #1090

Merged

Conversation

UtkarshBhatthere
Copy link
Contributor

No description provided.

@UtkarshBhatthere UtkarshBhatthere marked this pull request as draft August 2, 2023 12:16
@UtkarshBhatthere UtkarshBhatthere force-pushed the cephDashboardTest branch 13 times, most recently from eaa4ce3 to d05f49c Compare August 8, 2023 12:56
@UtkarshBhatthere UtkarshBhatthere marked this pull request as ready for review August 8, 2023 12:59
Copy link
Contributor

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, lgtm in general, some small nits/questions inline -- thanks!

zaza/openstack/charm_tests/ceilometer/tests.py Outdated Show resolved Hide resolved
zaza/openstack/charm_tests/ceph/dashboard/tests.py Outdated Show resolved Hide resolved
@UtkarshBhatthere UtkarshBhatthere force-pushed the cephDashboardTest branch 5 times, most recently from b3f681d to 39c4a76 Compare August 10, 2023 09:05
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

Copy link
Collaborator

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting a hold on this; there's some code strangeness that I'd like to comment on.

@ajkavanagh ajkavanagh merged commit 3b17ad9 into openstack-charmers:master Aug 16, 2023
3 checks passed
openstack-mirroring pushed a commit to openstack/charm-ceph-dashboard that referenced this pull request Aug 25, 2023
The fix adds event based handling of SSL configuration using charm
config and cleanup of SSL for relation and config based key/certs.
It also adds logical abstractions to analyse SSL setup and emit
relevant events.

Closes-Bug: 1952282
Change-Id: Ic486434526f639f5985cfe355e303c1d6ff5fa0d
Signed-off-by: utkarshbhatthere <[email protected]>
func-test-pr: openstack-charmers/zaza-openstack-tests#1090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants