-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Border widths #311
Comments
1px ash-lighter (d8d9db) is default for border buttons Button documentation from the OTKit wiki |
I think that's the 2 use cases I found. I see them a lot. Although 1px d8d9db is also quite commonly used as border-bottom and dividers. Do you think we should just provide a grouping then? Maybe for now, use the hex directly instead of figuring out how to reference the OTKit-colors? Like so:
I suck at names you should come up with names that make sense in design system, but you get my idea? @mannionaco |
i see, so there may be confusion when applying "border" as "dividing line" i think it makes sense that they are separate: dividing-line-default: border-default: border-hover (since this is being consumed in web i think it makes most sense to use words that are common, i use "active" as a global name vs by platform, but that's just me" border-selected (not sure if we need this? - probably make sense though, it's clear) what do you think? |
Hey Kellen @mannionaco, sorry I dropped the ball on this one. I think we still need to proceed with this approach, to put the entire divider definition into the borders token. Let me know if you have a more updated spec now, we can work together on this. |
@karuto i'll tag you in (abstract) the refined button styles so that our naming is clear. border-hover still applies and shouldn't be "active" as I reference above. border-selected = 2px red (not what i listed above) |
Thanks @mannionaco will talk to you in person about this |
Resolved by #428, moving the discussion over. |
I know that we didn't put the entire border declaration into the OTKit-borders token because we haven't decided how to let tokens reference each other yet.
But how about widths? I commonly see 1px, 2px etc. Is there a guideline on this? @mannionaco
The text was updated successfully, but these errors were encountered: