Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel avatar cooldown reduction and capacity not work #2150

Closed
3 of 5 tasks
jeswilldbm opened this issue Jan 25, 2024 · 4 comments · Fixed by #3058
Closed
3 of 5 tasks

Wheel avatar cooldown reduction and capacity not work #2150

jeswilldbm opened this issue Jan 25, 2024 · 4 comments · Fixed by #3058
Labels
Priority: Medium This issue may be impactful and needs some attention. Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@jeswilldbm
Copy link
Contributor

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

I was testing and when trying with the Master Sorcerer, it has some gems that reduce the energy wave by 1 second, when placed in the 4 available slots it correctly reduces 4 seconds of CD, but when trying with the runes that reduce the avatar by 300 seconds, it does not reduce even placing the 4 runes that do the same.
image
image
image
image
image
image

On the other hand, when adding a gem that adds capacity, it only increases by 1 or two points, when it should assign another amount, here I show the wheel without any gem as a reference:
image
Now I will add a "1000" capacity bonus:
image
Even if I add 1000 capacity, I only add 10 points.

This was tested in the latest available version of canary main downloaded today 01/25/2024 and without anything custom, as it comes as is.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeswilldbm jeswilldbm added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 25, 2024
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Jan 25, 2024
@Mirkaanks
Copy link
Contributor

We have a base, with time we will be doing work as well.

@dudantas dudantas changed the title Gem atelier does not work, avatar cooldown reduction and capacity Wheel avatar cooldown reduction and capacity not work Jan 26, 2024
@dudantas
Copy link
Member

dudantas commented Jan 26, 2024

Gems fix: #2152
Please update your issue.

Copy link
Contributor

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale No activity label Apr 26, 2024
@luanluciano93
Copy link
Contributor

luanluciano93 commented Jul 31, 2024

confirmed, capacity not work

uint32_t Player::getCapacity() const {
	if (hasFlag(PlayerFlags_t::CannotPickupItem)) {
		return 0;
	} else if (hasFlag(PlayerFlags_t::HasInfiniteCapacity)) {
		return std::numeric_limits<uint32_t>::max();
	}
	return capacity + bonusCapacity + varStats[STAT_CAPACITY] + m_wheelPlayer->getStat(WheelStat_t::CAPACITY);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be impactful and needs some attention. Stale No activity Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants