Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of bonuses in the look, cyclopedia and market #2896

Closed
3 of 5 tasks
rokamdev opened this issue Sep 16, 2024 · 1 comment
Closed
3 of 5 tasks

Display of bonuses in the look, cyclopedia and market #2896

rokamdev opened this issue Sep 16, 2024 · 1 comment
Labels
Priority: Critical Represents a risk to live servers Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@rokamdev
Copy link

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

When the item contains the mana leech and life leech bonus, it is displaying both the chance and amount values.

Canary:
Attack: 7 physical +45 death
Defence: 32 +3
Minimum Required Level: 400
Vocations: knights
Skill Boost: sword fighting +5, life leech chance +1.00%, life leech amount +5.00%, mana leech chance +1.00%, mana leech amount +3.00%
Weapon Type: sword
Weight: 63.00 oz
Imbuement Slots: 2
Classification: 4
Tier: 0

Global:
Attack: 7 physical +45 death
Defence: 32 +3
Minimum Required Level: 400
Vocations: knights
Skill Boost: sword fighting +5, life leech +5%, mana leech +3%
Weapon Type: stabbing weapon
Weight: 63.00 oz
Imbuement Slots: 2
Classification: 4
Tier: 0

The change should only display "life leech" or "mana leech" and the bonus display format would be a whole number (10%, 15%, 20%) and not a fractional number (10.00%, 15.00%, 20.00%).

When the item contains a critical bonus, it is correct to display both the chance and the extra damage, however the display should also be integer numbers (10%, 15%. 20%) and not fractional numbers (10.00%, 15.00%, 20.00%).

Canary:
Attack: 10 physical +47 ice
Defence: 35
Minimum Required Level: 400
Vocations: knights
Skill Boost: sword fighting +5, critical hit chance +10.00%, critical extra damage +10.00%
Weapon Type: sword, two-handed
Weight: 81.00 oz
Imbuement Slots: 3
Classification: 4
Tier: 0

Global:
Attack: 10 physical +47 ice
Defence: 35
Minimum Required Level: 400
Vocations: knights
Skill Boost: sword fighting +5, critical hit chance 10%, critical extra damage +10%
Weapon Type: stabbing weapon, two-handed
Weight: 81.00 oz
Imbuement Slots: 3
Classification: 4
Tier: 0

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rokamdev rokamdev added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 16, 2024
@github-actions github-actions bot added Priority: Critical Represents a risk to live servers Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Sep 16, 2024
@phacUFPE
Copy link
Contributor

phacUFPE commented Nov 5, 2024

This issue was solved in #2900

@phacUFPE phacUFPE closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Represents a risk to live servers Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants