Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: rework in Eventcallback "creatureOnHear" #3078

Closed
dudantas opened this issue Nov 8, 2024 · 0 comments · Fixed by #3076
Closed

Performance: rework in Eventcallback "creatureOnHear" #3078

dudantas opened this issue Nov 8, 2024 · 0 comments · Fixed by #3076
Assignees
Labels
Status: Pending Test This PR or Issue requires more testing

Comments

@dudantas
Copy link
Member

dudantas commented Nov 8, 2024

Apparently, the callback is being called for all creatures that are outside of IDLE, even for monsters. Monsters "do not need" to trigger the event for players (it’s the monsters that should "react" to the event triggered by players). From the analysis, it seems that monsters are calling the event for every player on the map.

NOTE: need disable "metrics lua" if metrics is disabled in the compilation level.

Image

@dudantas dudantas self-assigned this Nov 8, 2024
@dudantas dudantas converted this from a draft issue Nov 8, 2024
@github-actions github-actions bot added the Status: Pending Test This PR or Issue requires more testing label Nov 8, 2024
@dudantas dudantas linked a pull request Nov 8, 2024 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from In Progress to PRs Done in Canary - Release 3.5 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Test This PR or Issue requires more testing
Projects
Status: PRs Done
Development

Successfully merging a pull request may close this issue.

1 participant