Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset skill when player death #3127

Closed
2 of 5 tasks
mblldev opened this issue Nov 17, 2024 · 5 comments · Fixed by #3126
Closed
2 of 5 tasks

reset skill when player death #3127

mblldev opened this issue Nov 17, 2024 · 5 comments · Fixed by #3126
Labels
Priority: Critical Represents a risk to live servers Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@mblldev
Copy link

mblldev commented Nov 17, 2024 •
edited by murilo09
Loading

Priority

High

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

reset skill when player death

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mblldev mblldev added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 17, 2024
@github-actions github-actions bot added Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels Nov 17, 2024
@murilo09 murilo09 linked a pull request Nov 17, 2024 that will close this issue
fix: blessings calculations #3126
Merged
8 tasks
@murilo09 murilo09 added Priority: Critical Represents a risk to live servers and removed Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels Nov 17, 2024
@lopek7
Copy link

lopek7 commented Nov 17, 2024

Actually got the same problem, config.lua seems fine to me.

@mblldev
Copy link
Author

mblldev commented Nov 17, 2024

i have implement change #3126 but not fix problem with death lost skill

@mblldev mblldev closed this as completed Nov 17, 2024
@murilo09 murilo09 reopened this Nov 17, 2024
@murilo09
Copy link
Contributor

It will be closed when we merge the PR

@phacUFPE
Copy link
Contributor

phacUFPE commented Nov 17, 2024 •
edited
Loading

I tested the linked PR and it was not resetting the player skills anymore.

@phacUFPE
Copy link
Contributor

i have implement change #3126 but not fix problem with death lost skill

Did you guys compiled the source, replaced the exe and restarted the server after pulling the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical Represents a risk to live servers Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: blessings calculations opentibiabr/canary
4 participants
@phacUFPE @murilo09 @lopek7 @mblldev