Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: more reliable quickloot/autoloot #1997

Merged
merged 2 commits into from
Dec 14, 2023
Merged

improve: more reliable quickloot/autoloot #1997

merged 2 commits into from
Dec 14, 2023

Conversation

luan
Copy link
Contributor

@luan luan commented Dec 10, 2023

Instead of trying to quickloot at a location, we quickloot the corpse directly. This makes it so we deterministically pick up all the loot, instead of losing some depending on how and where monsters are dying.

@luan luan marked this pull request as ready for review December 10, 2023 02:58
@luan luan force-pushed the luan/reliable-autoloot branch from 507bc9b to 9a6b88d Compare December 11, 2023 06:31
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@luan luan merged commit 5c87e81 into main Dec 14, 2023
34 checks passed
@luan luan deleted the luan/reliable-autoloot branch December 14, 2023 03:54
luan added a commit that referenced this pull request Dec 28, 2023
* upstream/main: (28 commits)
  ci: enable merge_group in key builds for merge-queue (#2063)
  ci: disable sonar in draft prs and main branch (#2062)
  fix: check player nullptr and connection timeout (#2060)
  feat: namelocks (#2005)
  improve: connection management (#2040)
  fix: adventurer stone (#2048)
  fix: max limit of character name (#2035)
  fix: add missing 'alchemist container' monster (#2036)
  fix: players healing when attacked (#2026)
  fix: speed change issues (#2032)
  feat: the monster fight mechanics (#2001)
  fix: oberon arguments (#2021)
  fix: paladin speed on sharpshooter and swift foot (#2030)
  fix: skill food from hireling (#2028)
  improve: more reliable quickloot/autoloot (#1997)
  feat: configurable number of players per account (#2000)
  fix: potions conditions for group ids above senior tutors (#2019)
  fix: missing spell effect and file (#2020)
  fix: do not award bosstiary/bestiary points for summons (#2017)
  fix: correct spread value assignment from 1 to 0 (#2018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants