Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component as class name #2

Open
objectiser opened this issue Aug 7, 2017 · 4 comments
Open

Component as class name #2

objectiser opened this issue Aug 7, 2017 · 4 comments

Comments

@objectiser
Copy link

Currently using 'ejb' as the component name, with the invoked method name being the span's operation.

Wondering whether it would provide more useful information if the component tag was the class name? As this instrumentation is for internal use within the application, it may help users to understand the location in their code better if the combination of 'component' and 'operation' can be used to identify the class/method.

@jpkrohling
Copy link
Contributor

I'm not quite convinced about using the class name in the component field. What about assigning a tag of its own, like classname and method? On operation, we could set ClassName#method. Would that be acceptable?

@pavolloffay
Copy link
Contributor

I think that component should not be that fine grained. It should be used to retrieve spans from the same library.

Class name and method can be added as separate tags.

@objectiser
Copy link
Author

On re-reading 'component' definition it probably is better as just 'ejb' or 'cdi' - however it would be good to record the class. Depends whether having a composite operation is a good idea, or whether the method names will be understandable in their own right, with an additional 'className' tag for clarification?

@pavolloffay
Copy link
Contributor

Splitting class and method name is more flexible. e.g. It allows to query all methods from a given class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants