Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redisson Async Tracing #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dannylee-
Copy link

@dannylee- dannylee- commented Aug 2, 2022

Fixes the below scenario:

Issue Reproduction Steps:

  1. Start with no active span
  2. Run a Redis async call like "RedissonMap.getAsync().toCompletableFuture().get()"

Expected:
Spans are created and the call doesn't hang

Actual:
The get() function hangs

Notes on fix
I'm not 100% sure whether or not I should be activating the parent span or the built span in the continueScopeSpan function. I'm not sure why we would want to activate an already activated span, but it's possible that's how this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant