Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: why use a UUID for Span ID #13

Open
IUSR opened this issue Sep 13, 2019 · 1 comment
Open

Question: why use a UUID for Span ID #13

IUSR opened this issue Sep 13, 2019 · 1 comment

Comments

@IUSR
Copy link
Contributor

IUSR commented Sep 13, 2019

Is there a reason why a UUID is used? In the case of using Jaeger, I tested that all spans have hexadecimal IDs that can be parsed to 128-bit integers. Although the OpenTracing API doesn't require these IDs to be from numeric values, at least Jaeger is implemented in such away. When sending a span with a UUID span ID to Jaeger, I'm afraid it would complain about it, though I haven't been able to test this because all its client libraries demand a 128-bit integer.
If there's no strong reason, I'd suggest simply delegating to the wrapped span for span and trace Ids.

@NarimanAB
Copy link

NarimanAB commented Feb 14, 2020

I also think that in
private static final String BAGGAGE_SPANID_KEY = "reporter.spanId";
reporter.spanId must be reporter.spanid cause the default one is reporter.spanid.
with reporter.spanId the "baggage" contains two values with almost identical headers, but as I understand there must be only one with reporter.spanid key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants