Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanR.setTag() throws NPE when using null key/value #17

Open
kcirone opened this issue Nov 18, 2020 · 0 comments
Open

SpanR.setTag() throws NPE when using null key/value #17

kcirone opened this issue Nov 18, 2020 · 0 comments

Comments

@kcirone
Copy link

kcirone commented Nov 18, 2020

This is different behavior than, for example, Jaeger, due in part to Jaeger using a HashMap instead of a ConcurrentHashMap, the latter of which does not accept null values.

The fix would be to switch from using ConcurrentHashMap (which seems sensible given that spans really ought to be measuring operations on a single thread) OR at the very least checking for null. (FWIW the OpenTracing spec is mute on the subject of null tag values.)

@kcirone kcirone changed the title TracerR.setTag() throws NPE when using null key/value SpanR.setTag() throws NPE when using null key/value Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant