-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports the dictionary lookup feature to the fcitx5 version #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this PR we will have two dependecies which the last public release (2.5.2) didn't have: libicu-dev and libcjson-dev. Previously we only depend on everything that fcitx5 depends (e.g. libfmt-dev). Could this be a problem for potential package maintainers?
For example we would already have to update our Flatpak settings if we were to build against current HEAD. On the other hand, we can also let the Flatpak distribution (or other dist packages) stay at 2.5.2. I'm just wondering what the increased number of deps mean for development velocity (as we want more features) and ease of distribution. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm on vacation now, will take a look once I have access to my main Linux desktop (~ end of Jan). |
Apologies for the delay. On a typical Arch box, |
As the implementation on macOS, a user now can look up a phrase: