Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports the dictionary lookup feature to the fcitx5 version #103

Merged
merged 11 commits into from
Jan 2, 2024
Merged

Ports the dictionary lookup feature to the fcitx5 version #103

merged 11 commits into from
Jan 2, 2024

Conversation

zonble
Copy link
Collaborator

@zonble zonble commented Dec 31, 2023

As the implementation on macOS, a user now can look up a phrase:

  • by pressing the "?" key when selecting a candidate in the candidate window.
  • by pressing the "?" key when marked a range of the composing buffer.

@zonble zonble requested a review from lukhnos December 31, 2023 13:25
Copy link
Collaborator

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR we will have two dependecies which the last public release (2.5.2) didn't have: libicu-dev and libcjson-dev. Previously we only depend on everything that fcitx5 depends (e.g. libfmt-dev). Could this be a problem for potential package maintainers?

For example we would already have to update our Flatpak settings if we were to build against current HEAD. On the other hand, we can also let the Flatpak distribution (or other dist packages) stay at 2.5.2. I'm just wondering what the increased number of deps mean for development velocity (as we want more features) and ease of distribution. Thoughts?

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukhnos lukhnos merged commit c09a368 into openvanilla:master Jan 2, 2024
3 checks passed
@xatier
Copy link
Contributor

xatier commented Jan 8, 2024

I'm on vacation now, will take a look once I have access to my main Linux desktop (~ end of Jan).

@xatier
Copy link
Contributor

xatier commented Jan 25, 2024

Apologies for the delay.

On a typical Arch box, json-c is an indirect dependency of systemd and pkg-config is a dependency of base-devel, Arch users shouldn't see issues with these two packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants