Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit technical line wraps from displayed headers #4

Open
solardiz opened this issue Jul 28, 2024 · 0 comments
Open

Omit technical line wraps from displayed headers #4

solardiz opened this issue Jul 28, 2024 · 0 comments

Comments

@solardiz
Copy link
Member

Header lines may be wrapped for technical and standards compliance reasons. When we display message headers via the web, we currently include those technical line wraps intact. We should omit them. For example, we display:

https://www.openwall.com/lists/oss-security/2024/07/23/2

Subject: [OSSA-2024-002] OpenStack Nova: Incomplete file access fix and
 regression for QCOW2 backing files and VMDK flat descriptors
 (CVE-2024-40767)

but it should be:

Subject: [OSSA-2024-002] OpenStack Nova: Incomplete file access fix and regression for QCOW2 backing files and VMDK flat descriptors (CVE-2024-40767)

I thought this had something to do with:

                /* skip adjacent linear-white-space between previous
                 * encoded-word */
                r = --p;
                if (done != header) {
                        while (r > done && islinearwhitespace(*(--r)))
                                ;
                        if (r > done)
                                r = p;
                }
                buffer_append(dst, done, r - done);

and suspected this logic could be buggy or incomplete, but e.g. omitting if (r > done) r = p; made no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant