Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror verify error handling logic #367

Closed
kayaelle opened this issue Mar 17, 2023 · 10 comments
Closed

Mirror verify error handling logic #367

kayaelle opened this issue Mar 17, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request minor Fix when we can tech debt

Comments

@kayaelle
Copy link
Contributor

kayaelle commented Mar 17, 2023

From pivotal list.

Labels: shared verification library, web verifierplus

status: delivered ?

Created Oct 26, 2022

Requested by Seth

@kayaelle kayaelle added enhancement New feature or request import from pivotal labels Mar 20, 2023
@bmuramatsu
Copy link
Contributor

@kayaelle this one was for us having Atomic Jolt create a shared library to display the verification status that could be used in both LCW and VerifierPlus.

@kayaelle
Copy link
Contributor Author

kayaelle commented May 2, 2023

@dmitrizagidulin - was this delivered?

If not, can you provide some details to help lead the development? Thanks!

@kayaelle kayaelle moved this to LCW & Verfier Plus Issues in DCC Engineering Jul 17, 2023
@kayaelle
Copy link
Contributor Author

@dmitrizagidulin - have you been working on this as part of @contexts backwards-compatibility fix?

@kayaelle kayaelle moved this from LCW & Verfier Plus Backlog to Waiting/Blocked in DCC Engineering Jul 17, 2023
@dmitrizagidulin
Copy link
Contributor

Let me check to see if anything else remains...

@kayaelle
Copy link
Contributor Author

kayaelle commented Aug 9, 2023

Moving this to LCW-Backlog. The aim is to extract the verifier code into a library for re-use. Will do some dev planning with Dmitri.

@kayaelle kayaelle moved this from Waiting/Blocked to LCW Backlog in DCC Engineering Aug 9, 2023
@alexfigtree alexfigtree added minor Fix when we can medium and removed minor Fix when we can priority labels Mar 8, 2024
@alexfigtree
Copy link
Contributor

Questions remain on how to implement/how to best do this.

@alexfigtree alexfigtree added minor Fix when we can tech debt and removed medium labels Sep 4, 2024
@alexfigtree
Copy link
Contributor

@dmitrizagidulin says refactor is needed

@jchartrand
Copy link
Contributor

This common verification library will likely be used by:

  1. LCW
  2. VerifierPlus
  3. Our VC-API compliant verifier (https://test-issuer.dcconsortium/verifier)
  4. Any kind of react or web component that we build to allow issuers to embed verification logic directly into their site.
  5. The ORCID Ingester POC which will need to verify incoming VCs before posting them to ORCID

@jchartrand
Copy link
Contributor

jchartrand commented Dec 5, 2024

We will also need to add support for both the https://github.com/digitalbazaar/eddsa-rdfc-2022-cryptosuite suite in addition to the existing ed25519https://github.com/digitalbazaar/ed25519-signature-2020 suite and use whichever is appropriate for the given credential.

See
#656
digitalcredentials/verifier#2

@alexfigtree alexfigtree moved this from LCW Backlog to In Progress in DCC Engineering Dec 19, 2024
@alexfigtree
Copy link
Contributor

verifier-core related issue, closing this one

@github-project-automation github-project-automation bot moved this from In Progress to Done in Learner Credential Wallet Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Fix when we can tech debt
Projects
Status: Done
Development

No branches or pull requests

5 participants