Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samplicator: add samplicator #15553

Merged
merged 1 commit into from
May 6, 2021
Merged

samplicator: add samplicator #15553

merged 1 commit into from
May 6, 2021

Conversation

PolynomialDivision
Copy link
Member

@PolynomialDivision PolynomialDivision commented Apr 30, 2021 •
edited
Loading

Samplicator receives UDP datagrams on a given port and resends those datagrams to a specified set of receivers.

Use Cases:

  • replicate Flow Samples to multiple receivers
  • use with conntrackd to synchronize via unicast to multiple targets

Maintainer: me
Compile tested: trunk (ipq40xx)
Run tested: Mips WDR4300

@PolynomialDivision PolynomialDivision changed the title samplicator: add samplicator [WIP] samplicator: add samplicator Apr 30, 2021
@PolynomialDivision PolynomialDivision force-pushed the add-samplicator branch 5 times, most recently from 6c9c19f to 389d574 Compare May 1, 2021 06:39
@PolynomialDivision PolynomialDivision changed the title [WIP] samplicator: add samplicator samplicator: add samplicator May 1, 2021
@PolynomialDivision PolynomialDivision marked this pull request as ready for review May 1, 2021 06:39
@PolynomialDivision
Copy link
Member Author

Sadly, the PID file stuff is not in the stable release.

spolack
spolack reviewed May 1, 2021
View reviewed changes
net/samplicator/files/samplicator.init Outdated
}

reload_service() {
procd_send_signal bird
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bird?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed. Copied the relevant stuff from bird init file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed reloading completely.

@PolynomialDivision PolynomialDivision force-pushed the add-samplicator branch 2 times, most recently from 5fefbef to 2e9dd21 Compare May 1, 2021 08:39
BKPepe
BKPepe reviewed May 2, 2021
View reviewed changes
net/samplicator/Makefile Outdated
PKG_HASH:=3c4358b4b0992a77251f2b9e2221d4ae945781160732c73504eb126e69d72d40

PKG_MAINTAINER:=Nick Hainke <[email protected]>
PKG_LICENSE:=GPL-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated SPDX License Identifier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to GPL-2.0-only. Sry, I do always just searching for the identifier. Did not see that it is in the deprecated section. xD

net/samplicator/Makefile Outdated Show resolved Hide resolved
net/samplicator/Makefile Outdated Show resolved Hide resolved
@PolynomialDivision PolynomialDivision requested a review from BKPepe May 2, 2021 08:16
@PolynomialDivision
Copy link
Member Author

BTW.: sleinen/samplicator#73

@PolynomialDivision
Copy link
Member Author

@BKPepe Still something left? Otherwise I would like to merge.

@BKPepe
Copy link
Member

BKPepe commented May 3, 2021

Why are you shipping an empty config file? And then the second question, why do we need to have it merged, why this package it useful/what is your usage? Can you also add test.sh file to have it run-tested?

@PolynomialDivision
Copy link
Member Author

Why are you shipping an empty config file?

I can put there an example config.

And then the second question, why do we need to have it merged, why this package it useful/what is your usage?

We want to use conntrackd to synchronize state-full firewall rules across multiple gateways. To my knowledge, conntracd only has the ability to do this via unicast to one target. That is why we want to use samplicator to samplicate those "control messages".

Can you also add test.sh file to have it run-tested?

Never did this. I have to check how this works.

@PolynomialDivision
Copy link
Member Author

Can you also add test.sh file to have it run-tested?

@BKPepe After looking at the test.sh files, it looks like everyone is just checking for the correct version. Sadly, samplicator has no cmd to check the version.

@PolynomialDivision
samplicator: add samplicator
41534e5 
Samplicator receives UDP datagrams on a given port and resends those
datagrams to a specified set of receivers.

Use Cases:
- replicate Flow Samples to multiple receivers
- use with conntrackd to synchronize via unicast to multiple targets

Signed-off-by: Nick Hainke <[email protected]>
@PolynomialDivision
Copy link
Member Author

@BKPepe is it fine without test.sh?

@neheb neheb merged commit ff76ee7 into openwrt:master May 6, 2021
@PolynomialDivision
Copy link
Member Author

Here is what we do:
freifunk-berlin/bbb-configs@c615c35

@PolynomialDivision PolynomialDivision deleted the add-samplicator branch January 20, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolack spolack spolack left review comments

@BKPepe BKPepe Awaiting requested review from BKPepe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PolynomialDivision @BKPepe @spolack @neheb