Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloaded call to buildMessage #364

Open
zacnelson opened this issue Aug 9, 2016 · 0 comments
Open

Overloaded call to buildMessage #364

zacnelson opened this issue Aug 9, 2016 · 0 comments
Labels

Comments

@zacnelson
Copy link

Discussion on the Google group: https://groups.google.com/forum/?pli=1#!topic/openxc/RDy7XYZOEKA

Kyle Kelly found a bug in the buildMessage function here: https://github.com/openxc/vi-firmware/blob/master/src/can/canwrite.cpp#L12

This function is called after a custom encoder is used. The custom encoder returns a uint64_t value, but buildMessage and the used bitfiled-c functions only accept type int. Here's where buildMessage is called after a custom encoding is completed: https://github.com/openxc/vi-firmware/blob/master/src/can/canwrite.cpp#L131

@zacnelson zacnelson added the bug label Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant