Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace referenced images/other content #21

Open
josephlewis42 opened this issue Sep 11, 2024 · 1 comment
Open

Replace referenced images/other content #21

josephlewis42 opened this issue Sep 11, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
later

Comments

@josephlewis42
Copy link
Collaborator

Godot, and possibly other documentation references images that are hotlinked from the Internet that won't work offline.

This is consistent with the experience you'd get with DevDocs in offline mode, but is a poor overall experience.

The scraper should download these images and serve them from the Zim (possibly also caching them to S3).
@josephlewis42 josephlewis42 added the enhancement New feature or request label Sep 11, 2024
@josephlewis42 josephlewis42 added this to the later milestone Sep 11, 2024
@josephlewis42 josephlewis42 mentioned this issue Sep 11, 2024
Merged
@benoit74
Copy link
Contributor

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
later
Development

No branches or pull requests
2 participants
@josephlewis42 @benoit74