You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> [email protected] build
> ./dev/build.sh
Building at [Mon Jan 13 09:40:41 UTC 2025]
Error: node_modules/@types/imagemin-gifsicle/index.d.ts(7,24): error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("imagemin")' call instead.
Error: node_modules/@types/imagemin-webp/index.d.ts(7,24): error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("imagemin")' call instead.
Error: node_modules/split-by-grapheme/index.ts(2,15): error TS2339: Property 'Segmenter' does not exist on type 'typeof Intl'.
Error: node_modules/split-by-grapheme/index.ts(3,16): error TS2339: Property 'Segmenter' does not exist on type 'typeof Intl'.
Build Complete at [Mon Jan 13 09:40:49 UTC 2025]
I think two things needs to be fixed:
we shouldn't have these errors
we should have silent errors in the build process (errors should fail the build)
The text was updated successfully, but these errors were encountered:
AFAIK, at least for the two firsts, they depend indirectly to the adoption of recent version of gyp which itself depends of latest version of node-libzim.
Yes, I have been seeing those errors since I started working on mwoffliner, and I have no idea where they come from or what they are (from library code with old versions of node/ts maybe?), but they were very confusing the first time I saw them, especially since not only do they not fail the build process, but mwoffliner runs and works fine after they scroll past.
No hurry to fix them from my PoV, but better to have an issue to track the problem and bring awareness, especially about the fact that it is a known problem and we didn't found a simple solution.
See e.g. https://github.com/openzim/mwoffliner/actions/runs/12744447456/job/35516375224 (or any more recent
CI
job).I think two things needs to be fixed:
The text was updated successfully, but these errors were encountered: