Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better youtube_dl requests mgmt #122

Open
rgaudin opened this issue Sep 18, 2020 · 2 comments
Open

Better youtube_dl requests mgmt #122

rgaudin opened this issue Sep 18, 2020 · 2 comments
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Sep 18, 2020

The new structure from #119 PR accidentally strengthen something wrong in our requests management. Every youtube_dl call leads to a request to the video webpage from which youtube_dl extracts the information it needs to then

  • download the video file(s)
  • download the thumbnail(s)
  • download the subtitle(s)
    As this webpage is subject to the quota, this is not very efficient as we'd call it 3 times in case we have nothing for that video in S3.

We should also probably save those subtitles in S3 although those can change over time. As for thumbnails, I don't think this matters much until users raise concern about subtitles being outdated (then we'd expire them after some time).

@stale
Copy link

stale bot commented Nov 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Nov 18, 2020
@benoit74 benoit74 added this to the 3.1.0 milestone Jul 23, 2024
@stale stale bot removed the stale label Jul 23, 2024
@benoit74
Copy link
Collaborator

Need to be done together with #177

And caching S3 subtitles is now tracked as #277

@benoit74 benoit74 modified the milestones: 3.1.0, 3.2.0 Sep 5, 2024
@benoit74 benoit74 modified the milestones: 3.2.0, 3.3.0 Oct 11, 2024
@benoit74 benoit74 modified the milestones: 3.3.0, 3.4.0 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants