Handling of external links seems incoherent

[kelson42]

At https://dev.library.kiwix.org/viewer#mes-quartiers-chinois_fr_all_2023-02/A/mesquartierschinois.wordpress.com/

If I click on the link « deux solitudes », it opens directly the Wikipedia link in a new tab.

But if I click on « plutot chouette » I get

Not sure what shoukd be the correct behaviour, but this seems incoherent.

[rgaudin]

The WP link is opened in a new tab, as requested by the original website (target _blank). Allowing this, we are deferring rendering to the browser and the rest is not part of the ZIM or replayer. As the URL is an online and working one, it's displayed properly.

The other link on the other hand is a regular link and thus goes through our Service Worker that notices it's not included in the ZIM and displays an appropriate message.

That's for why this happens. I agree user don't mind about this and we should have a coherent behavior.

• Should we allow new-tab links?
• Should we improve the not found page design and offer a link (on a new tab) to the online location? Kind of what we have on kiwix-serve

[benoit74]

Issue has changed a bit with Zimit2, where behavior is now coherent so we can probably close this issue.

There is still one weird thing but for me it is a kiwix-serve bug:

• with https://dev.library.kiwix.org/viewer#mes-quartiers-chinois_fr_all_2024-05/mesquartierschinois.wordpress.com/ when the target is _blank ("deux solitudes" for instance), then the link is opened both in a new tab and in the current one.
• with https://dev.library.kiwix.org/content/mes-quartiers-chinois_fr_all_2024-05/mesquartierschinois.wordpress.com/ it works as expected.

Shall we close this ticket and open a kiwix-serve issue?

[rgaudin]

Yep!

[benoit74]

openzim/libzim#887 is opened, closing this one.