Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3SingleFormat.FormatMaxLength short by 1 #245

Open
yanxke opened this issue Dec 27, 2020 · 2 comments
Open

B3SingleFormat.FormatMaxLength short by 1 #245

yanxke opened this issue Dec 27, 2020 · 2 comments

Comments

@yanxke
Copy link

yanxke commented Dec 27, 2020

private const int FormatMaxLength = 32 + 1 + 16 + 2 + 16; // traceid128-spanid-1-parentid

Right now it adds up to 67. Should be 68.

@nnminh98
Copy link

nnminh98 commented Apr 2, 2023

I don't understand the exact problem here. Can you elaborate?

@yanxke
Copy link
Author

yanxke commented Apr 3, 2023

If you look at the sample

/// <code>4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-d-5b4185666d50f68b</code>
it is 68 characters long, but this is defined to only hold 67 characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants