Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add check in test-e2e testing to ensure there's a cluster #474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 26, 2024

No description provided.

@tmshort tmshort requested a review from a team as a code owner November 26, 2024 21:38
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (adf64a0) to head (fa24b24).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort marked this pull request as draft November 26, 2024 21:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
camilamacedo86

This comment was marked as outdated.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@camilamacedo86

This comment was marked as outdated.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@camilamacedo86
Copy link
Contributor

Hi @tmshort

I think in the way that is writing, the problem might be how we are getting the kubeconfig and client.
Just, an idea we might need to do something like:

If we want still doing in this way.

@camilamacedo86 camilamacedo86 dismissed their stale review November 27, 2024 02:40

based on the above comment.

@tmshort tmshort marked this pull request as ready for review December 2, 2024 15:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants