You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm currently updating in my project josdk to the 5.0.0-beta1. So I am currently reading through the documentation in order to update the registration of the EventSources in my reconcilers.
I have thought about the following topics/suggestions:
I came across the following examples while updating:
From what I can see, the “InformerConfiguration” class does not provide a “from” method anymore (changed with v5). In the example, this should rather be the class “InformerEventSourceConfiguration”, can that be?
The examples in the documentation (such as the one mentioned above) show a simple configuration of an ES using the “InformerEventSourceConfiguration” class and refer to an example in an integration test. Some configurations are now also carried out via the “InformerConfiguration” class (e.g. setting onUpdateFilter), it would perhaps also be helpful to integrate an example of this into the documentation, or to refer to an integration test that contains such a config, such as this one.
The Migration Guide mentions the prepareEventSources method, but does not describe what needs to be adapted there. Perhaps it would be helpful to refer to the documentation for an example.
This link in the Migration Guide is not accessible and should be adjusted.
This example in the documentation is outdated. It should be updated to context. managedWorkflowAndDependentResourceContext(), right?
What do you think about these topics?
Best regards
Martin
The text was updated successfully, but these errors were encountered:
Hey,
I'm currently updating in my project josdk to the 5.0.0-beta1. So I am currently reading through the documentation in order to update the registration of the EventSources in my reconcilers.
I have thought about the following topics/suggestions:
java-operator-sdk/docs/content/en/docs/features/_index.md
Line 476 in 9911a63
java-operator-sdk/docs/content/en/docs/features/_index.md
Line 675 in 9911a63
From what I can see, the “InformerConfiguration” class does not provide a “from” method anymore (changed with v5). In the example, this should rather be the class “InformerEventSourceConfiguration”, can that be?
The examples in the documentation (such as the one mentioned above) show a simple configuration of an ES using the “InformerEventSourceConfiguration” class and refer to an example in an integration test. Some configurations are now also carried out via the “InformerConfiguration” class (e.g. setting onUpdateFilter), it would perhaps also be helpful to integrate an example of this into the documentation, or to refer to an integration test that contains such a config, such as this one.
The Migration Guide mentions the prepareEventSources method, but does not describe what needs to be adapted there. Perhaps it would be helpful to refer to the documentation for an example.
This link in the Migration Guide is not accessible and should be adjusted.
This example in the documentation is outdated. It should be updated to
context. managedWorkflowAndDependentResourceContext()
, right?What do you think about these topics?
Best regards
Martin
The text was updated successfully, but these errors were encountered: