Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: release 5 blogpost #2558

Closed
wants to merge 88 commits into from
Closed

docs: release 5 blogpost #2558

wants to merge 88 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Oct 25, 2024

The first version of the blogpost, will be probably extended with subsequent PR-s

csviri and others added 30 commits October 10, 2024 10:42
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <[email protected]>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
…ed (#2297)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri and others added 10 commits October 10, 2024 11:25
Signed-off-by: Attila Mészáros <[email protected]>
* imporve diff logging

Signed-off-by: bachmanity1 <[email protected]>

* compute diff only when actual doesn't match desired

Signed-off-by: bachmanity1 <[email protected]>

* slight improvements

Signed-off-by: bachmanity1 <[email protected]>

* increase context size

Signed-off-by: bachmanity1 <[email protected]>

* fix style

Signed-off-by: bachmanity1 <[email protected]>

* calculate diff only if debug is enabled

Signed-off-by: bachmanity1 <[email protected]>

* print actual resources when trace is enabled

Signed-off-by: bachmanity1 <[email protected]>

* use java-diff-utils

Signed-off-by: bachmanity1 <[email protected]>

* add unit tests

---------

Signed-off-by: bachmanity1 <[email protected]>
* feat(build): split ITs by category, parallel CRD generation

Also avoid generating CRDs when not needed by default, summarizes test
results.

* chore(deps): bump actions-setup-minikube to 2.13.0
* feat: default to use vertx client
* chore(ci): reduce tested combinations, only run client tests on baseapi
* fix: increase deletion timeout

---------

Signed-off-by: Chris Laprun <[email protected]>
@csviri csviri mentioned this pull request Oct 25, 2024
@csviri csviri requested review from metacosm and xstefank October 25, 2024 09:03
@csviri csviri self-assigned this Oct 25, 2024
@csviri csviri linked an issue Oct 25, 2024 that may be closed by this pull request
@metacosm metacosm force-pushed the next branch 2 times, most recently from bad7c53 to 0efc6d3 Compare November 6, 2024 09:31
@metacosm
Copy link
Collaborator

metacosm commented Nov 7, 2024

It might be better to simply cherry-pick the changes in a new branch than trying to rebase since it seems rather complex for some reason. It also looks like some changes got into that branch that shouldn't have made it in there (adding the controller-namespace-deletion sample, for example).

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csviri
Copy link
Collaborator Author

csviri commented Nov 7, 2024

It might be better to simply cherry-pick the changes in a new branch than trying to rebase since it seems rather complex for some reason. It also looks like some changes got into that branch that shouldn't have made it in there (adding the controller-namespace-deletion sample, for example).

Sure, will do it a bit later. thx

Signed-off-by: Attila Mészáros <[email protected]>

Update docs/content/en/blog/releases/v5-release.md

Co-authored-by: Martin Stefanko <[email protected]>

Update docs/content/en/blog/releases/v5-release.md

Co-authored-by: Martin Stefanko <[email protected]>
@csviri
Copy link
Collaborator Author

csviri commented Nov 16, 2024

replaced by: #2583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants