Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some more nit fixes to the documentation. #246

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Ankit152
Copy link
Contributor

@Ankit152 Ankit152 commented Jul 7, 2022

Signed-off-by: Ankit Kurmi [email protected]

Description

Fixed some underlying typos in the content/en/docs/Tasks directory.

@openshift-ci openshift-ci bot requested review from anik120 and ankitathomas July 7, 2022 09:38
@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankit152
To complete the pull request process, please assign kevinrizza after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevinrizza in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ankit152
Copy link
Contributor Author

Hey @camilamacedo86 🙂
Can you please take a look here?

Copy link
Collaborator

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the linter failed before, I don't see anything that could fail the linter. Unfortunately the logs from the run aren't available anymore, and I don't see the option to re-run the test either. I think it's fine for us to merge this one. Pretty small changes and again, I don't see anything that could fail the linter test.

@grokspawn grokspawn added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2024
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@perdasilva perdasilva enabled auto-merge (squash) November 25, 2024 09:58
@perdasilva perdasilva merged commit 9142381 into operator-framework:master Nov 25, 2024
5 of 6 checks passed
@Ankit152 Ankit152 deleted the yet-another-doc-fix branch November 25, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants