Skip to content

Commit

Permalink
(fix) Removing Unused and Insecure Manifests for Prometheus
Browse files Browse the repository at this point in the history
We are not using these manifests or supporting this option. Therefore, they should be removed, as they are not configured to use certificates and have insecureSkipVerify: false, which promotes an insecure setup by default.

If we want enable this option then we need configure it with:

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    control-plane: operator-controller-controller-manager
  name: controller-manager-metrics-monitor
  namespace: system
spec:
  endpoints:
    - path: /metrics
      port: https
      scheme: https
      bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
      tlsConfig:
        insecureSkipVerify: false
        ca:
          secret:
            name: olmv1-cert
            key: ca.crt
        cert:
          secret:
            name: olmv1-cert
            key: tls.cert
        keySecret:
          name: olmv1-cert
          key: tls.key
  selector:
    matchLabels:
      control-plane: operator-controller-controller-manager
```
  • Loading branch information
camilamacedo86 committed Dec 13, 2024
1 parent 61fe142 commit 85f94da
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
2 changes: 0 additions & 2 deletions config/base/prometheus/kustomization.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions config/base/prometheus/monitor.yaml

This file was deleted.

0 comments on commit 85f94da

Please sign in to comment.