Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for labeling webhooks and selector #1115

Closed
Tracked by #1028
tmshort opened this issue Aug 12, 2024 · 1 comment · Fixed by #1237
Closed
Tracked by #1028

E2E tests for labeling webhooks and selector #1115

tmshort opened this issue Aug 12, 2024 · 1 comment · Fixed by #1237
Assignees
Labels
epic/catalog-selection v1.0 Issues related to the initial stable release of OLMv1
Milestone

Comments

@tmshort
Copy link
Contributor

tmshort commented Aug 12, 2024

There is a composed system to make the final correct response happen: one, or possibly two, webhooks -- a mutating webhook and possibly a validating webhook to enforce policy; operator-controller, catalogd. Because of this composed system, we should have add at least one e2e that confirms the happy path outcome works.

@everettraven everettraven added this to the v1.0.0 milestone Aug 20, 2024
@tmshort tmshort added this to OLM v1 Aug 27, 2024
@tmshort tmshort moved this to Accepted in OLM v1 Aug 27, 2024
@everettraven everettraven added the v1.0 Issues related to the initial stable release of OLMv1 label Aug 27, 2024
@tmshort
Copy link
Contributor Author

tmshort commented Sep 4, 2024

This should be done in both catalogd and operator-controller.

Looks extremely straightforward to augment the existing e2e here: https://github.com/operator-framework/catalogd/blob/db28a52cd57400cbdac88f42e00bc2d4eabcff84/test/e2e/unpack_test.go#L64

Right after create succeeds, we can check that catalog var for the right label/value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/catalog-selection v1.0 Issues related to the initial stable release of OLMv1
Projects
Archived in project
2 participants