-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ✨ Add support for registry+v1 bundles that include webhooks #1506
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
==========================================
- Coverage 74.68% 73.54% -1.15%
==========================================
Files 42 46 +4
Lines 3271 3931 +660
==========================================
+ Hits 2443 2891 +448
- Misses 652 811 +159
- Partials 176 229 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
426d2a2
to
a966abd
Compare
So under |
bfac949
to
f91d692
Compare
@bentito I intend on completely removing the cloudnative-pg stuff before we merge. That is just there as an example of the transformation that the bundle to a chart, as performed by that command. I would probably also remove that entire |
b5f77d1
to
d0c6d90
Compare
07720cf
to
b9f4233
Compare
Signed-off-by: Joe Lanford <[email protected]>
b9f4233
to
e2bfeef
Compare
Description
This PR adds support for bundles that define webhooks via:
RegistryV1WebhookSupport
that is disabled by default--registry-v1-cert-provider
flag for the manager binary (only present when the feature gate is enabled) that allows someone installing OLMv1 to specify a certificate provider to use for registry+v1 webhooks.The PR also has a small demo program (
cmd/registryv1-to-helm
) and some example input/output (using cloudnative-pg) that is a light wrapper around theinternal/rukpak/convert
library. I intend to remove all of this before the PR merges.Reviewer Checklist