Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45490: catalog-operator: Delete Pods that were evicted #3459

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

simonkrenger
Copy link
Contributor

Description of the change:

This change adds another reason why a Pod could be detected as "dead", namely when it was evicted by the kubelet. This can happen when there is resource pressure on the Node. Then the reason will be "TerminationByKubelet".

Motivation for the change:

This addresses the issue described in https://issues.redhat.com/browse/OCPBUGS-45490

Architectural changes:

None

Testing remarks:

None

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

This change adds another reason why a Pod could be detected as "dead",
namely when it was evicted by the kubelet. This can happen when there is
resource pressure on the Node. Then the reason will be
"TerminationByKubelet".

This addresses the issue described in
https://issues.redhat.com/browse/OCPBUGS-45490

Signed-off-by: Simon Krenger <[email protected]>
Copy link

openshift-ci bot commented Dec 6, 2024

Hi @simonkrenger. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2024
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@anik120 anik120 removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2024
@joelanford joelanford enabled auto-merge December 6, 2024 15:16
@joelanford joelanford added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@anik120 anik120 added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@anik120 anik120 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into operator-framework:master with commit 8e39847 Dec 6, 2024
12 checks passed
@simonkrenger simonkrenger deleted the OCPBUGS-45490 branch December 11, 2024 12:04
perdasilva pushed a commit to perdasilva/operator-lifecycle-manager that referenced this pull request Dec 12, 2024
)

This change adds another reason why a Pod could be detected as "dead",
namely when it was evicted by the kubelet. This can happen when there is
resource pressure on the Node. Then the reason will be
"TerminationByKubelet".

This addresses the issue described in
https://issues.redhat.com/browse/OCPBUGS-45490

Signed-off-by: Simon Krenger <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants