From 2ad579f2648b1169d297dbc6c33137bf80530a37 Mon Sep 17 00:00:00 2001 From: Kabiru Mwenja Date: Mon, 9 Dec 2024 16:01:06 +0300 Subject: [PATCH] Add full stop on relative time as per design The full stop acts a separator between the relative time and note --- .../in-app-notification-relative-time.component.ts | 2 +- .../notification_center/notification_center_reminder_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/app/features/in-app-notifications/entry/relative-time/in-app-notification-relative-time.component.ts b/frontend/src/app/features/in-app-notifications/entry/relative-time/in-app-notification-relative-time.component.ts index 3f3b1801cff4..153e658175a7 100644 --- a/frontend/src/app/features/in-app-notifications/entry/relative-time/in-app-notification-relative-time.component.ts +++ b/frontend/src/app/features/in-app-notifications/entry/relative-time/in-app-notification-relative-time.component.ts @@ -55,7 +55,7 @@ export class InAppNotificationRelativeTimeComponent implements OnInit { return this.text.updated_by_at(time); } - return time; + return `${time}.`; }), distinctUntilChanged(), ); diff --git a/spec/features/notifications/notification_center/notification_center_reminder_spec.rb b/spec/features/notifications/notification_center/notification_center_reminder_spec.rb index d1f3cf3c04bd..3b9f45e28aec 100644 --- a/spec/features/notifications/notification_center/notification_center_reminder_spec.rb +++ b/spec/features/notifications/notification_center/notification_center_reminder_spec.rb @@ -51,7 +51,7 @@ center.within_item(notification_reminder) do expect(page).to have_text("Date alert, Mentioned, Reminder") expect(page).to have_no_text("Actor user") - expect(page).to have_text("a few seconds ago\nNote: “This is an important reminder”") + expect(page).to have_text("a few seconds ago.\nNote: “This is an important reminder”") end end end